Skip to content

fix: crash on Mii Editor: Font Size 0#290

Merged
matellush merged 4 commits into
TeamWheelWizard:devfrom
Alexis-Lapierre:main
Jun 18, 2026
Merged

fix: crash on Mii Editor: Font Size 0#290
matellush merged 4 commits into
TeamWheelWizard:devfrom
Alexis-Lapierre:main

Conversation

@Alexis-Lapierre

@Alexis-Lapierre Alexis-Lapierre commented Jun 16, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

For some reasons when I pick the precompiled Linux version everything works as expected. But building from source result the following Avalonia crash:

System.ArgumentException: 0 is not a valid value for 'FontSize'.
at Avalonia.PropertyStore.ValueStore.SetValue[T](StyledProperty`1 property, T value, BindingPriority priority)

Don’t really know why. Could have built this application with a different Avalonia version? I don’t really use C# usually so I can’t give specifics.

Purpose of this PR:

Fix a crash by removing a FontSize attribute from something that does not have a FontSize

How to Test:

What Has Been Changed:

WheelWizard/Views/Components/PopupListButton.axaml: drop FontSize="0".

Behavior unchanged as the related Views/Components/IconLabel.axaml only use FontSize attribute with a Text attribute alongside it to feed a TextBlock.

Related Issue Link:

Checklist before merging

  • You have created relevant tests

Summary by CodeRabbit

  • Bug Fixes
    • Fixed the arrow icon in PopupListButton to display correctly. The icon was previously hidden due to an incorrect size setting and is now visible with proper rendering.

patchzyy and others added 4 commits June 1, 2026 02:37
@patchzyy
Merge pull request TeamWheelWizard#280 from TeamWheelWizard/dev
1db6eb8 
Release 2.4.8
@patchzyy
Merge pull request TeamWheelWizard#281 from TeamWheelWizard/dev
3dcd8a0 
Release 2.4.9
@patchzyy
Merge dev into main for release 2.4.10
8df6d60
@Alexis-Lapierre
Fix crash on Mii Editor: Font Size 0
9b111f7 
For some reasons when I pick the precompiled Linux version everything works as expected.
But building from source result in an Avalonia crash:
> System.ArgumentException: 0 is not a valid value for 'FontSize'.
>   at Avalonia.PropertyStore.ValueStore.SetValue[T](StyledProperty`1 property, T value, BindingPriority priority)

Don’t really know why. Could have built this application with a different Avalonia version? I don’t really use C# usually.
@coderabbitai

coderabbitai Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d9e6b3fa-8daa-4fb4-8f59-cee503d36fbc

📥 Commits

Reviewing files that changed from the base of the PR and between 8df6d60 and 9b111f7.

📒 Files selected for processing (1)
  • WheelWizard/Views/Components/PopupListButton.axaml
📝 Walkthrough

Walkthrough

Removes the FontSize="0" attribute from the PART_ArrowIcon IconLabel element in the PopupListButton control template, allowing the arrow icon to render at its default font size. Also includes a minor trailing whitespace adjustment at the end of the AXAML file.

Changes

PopupListButton Arrow Icon Visibility Fix

Layer / File(s) Summary
Remove FontSize=0 from PART_ArrowIcon
WheelWizard/Views/Components/PopupListButton.axaml		 The PART_ArrowIcon IconLabel no longer sets FontSize="0", enabling the arrow icon to display at its default/template font size. A trailing whitespace adjustment accompanies the change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A zero font size hid the arrow away,
No chevron to guide you, no point to display.
One attribute dropped, and the icon appears —
The wizard's direction is finally clear!
🐇✨ The arrow is back, hip-hip-hooray!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing FontSize 0 that caused a crash in the Mii Editor, directly matching the core fix in the changeset.
Description check ✅ Passed The description includes all template sections with substantive content: Purpose (fixing crash by removing FontSize attribute), How to Test (not applicable for this fix), What Has Been Changed (detailed explanation of the removal and rationale). The description is complete and addresses the required template structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Alexis-Lapierre

Alexis-Lapierre commented Jun 16, 2026

Copy link
Copy Markdown
Author

To be clear: CodeRabbit is not 100% accurate.

Also for more context: the original issue I had is that the WheelWizard packaged by NixOS has this crashing issue. I tried a more regular distribution, and Arch linux package is good.

@matellush matellush changed the base branch from main to dev June 18, 2026 10:45
@matellush matellush enabled auto-merge June 18, 2026 11:03
@matellush matellush self-requested a review June 18, 2026 11:03
@matellush matellush merged commit 8b77e09 into TeamWheelWizard:dev Jun 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matellush matellush matellush approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alexis-Lapierre @matellush @patchzyy